tools: automate zlib update #47417

marco-ippolito · 2023-04-05T09:59:59Z

Refs: nodejs/security-wg#828
@nodejs/security-wg

nodejs-github-bot · 2023-04-05T10:00:04Z

Review requested:

@nodejs/actions

lpinca · 2023-04-05T18:50:12Z

tools/dep_updaters/update-zlib.sh

+
+CURRENT_VERSION=$(grep "#define ZLIB_VERSION" "$DEPS_DIR/zlib/zlib.h" | sed -n "s/^.*VERSION \"\(.*\)\"/\1/p")
+
+NEW_VERSION_ZLIB_H=$(curl -s "https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/zlib/zlib.h?format=TEXT" | base64 --decode)


This works but it might remain the same for a very long time. It is not very useful. We refer to the tip of the remote main branch to check if an update is needed. However, afaik, we store the current commit SHA only in the commit message.

I havent found any other solution to check what's the latest version, I think this might be a reasonable compromise and its not very expensive

That's fine but it probably won't find a new version for years. See https://github.com/madler/zlib/tags.

@lpinca are you saying that we typically update to something that is not a new release? If so then an option in the script/action to say generate PR based on commit X instead of a new version might make sense.

are you saying that we typically update to something that is not a new release?

Yes, exactly.

I think we should probably change it in the future to something like @tniessen did in this PR #47482

tools/dep_updaters/update-zlib.sh

ShogunPanda

LGTM!

nodejs-github-bot · 2023-04-12T13:18:16Z

Commit Queue failed

- Loading data for nodejs/node/pull/47417
✔  Done loading data for nodejs/node/pull/47417
----------------------------------- PR info ------------------------------------
Title      tools: automate zlib update (#47417)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/automate-zlib-update -> nodejs:main
Labels     meta, tools, author ready
Commits    1
 - tools: automate zlib update
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/47417
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47417
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - tools: automate zlib update
   ℹ  This PR was created on Wed, 05 Apr 2023 09:59:59 GMT
   ✔  Approvals: 2
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376059006
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376413213
   ⚠  This PR has conflicts that must be resolved
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4678748046

RafaelGSS

LGTM. Rebase to resolve the conflicts

nodejs-github-bot · 2023-04-17T16:56:26Z

Commit Queue failed

- Loading data for nodejs/node/pull/47417
✔  Done loading data for nodejs/node/pull/47417
----------------------------------- PR info ------------------------------------
Title      tools: automate zlib update (#47417)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/automate-zlib-update -> nodejs:main
Labels     meta, tools, author ready
Commits    1
 - tools: automate zlib update
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/47417
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47417
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - tools: automate zlib update
   ℹ  This PR was created on Wed, 05 Apr 2023 09:59:59 GMT
   ✔  Approvals: 3
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376059006
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376413213
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47417#pullrequestreview-1386302187
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4723740689

nodejs-github-bot · 2023-04-18T09:21:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/47417
✔  Done loading data for nodejs/node/pull/47417
----------------------------------- PR info ------------------------------------
Title      tools: automate zlib update (#47417)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/automate-zlib-update -> nodejs:main
Labels     meta, tools, author ready
Commits    1
 - tools: automate zlib update
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/47417
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47417
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - tools: automate zlib update
   ℹ  This PR was created on Wed, 05 Apr 2023 09:59:59 GMT
   ✔  Approvals: 3
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376059006
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376413213
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47417#pullrequestreview-1386302187
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4730739601

mhdawson

LGTM with a question.

nodejs-github-bot · 2023-04-19T08:25:56Z

Landed in 8f879de

PR-URL: #47417 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#47417 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

marco-ippolito requested a review from lpinca April 5, 2023 10:00

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 5, 2023

marco-ippolito force-pushed the feat/automate-zlib-update branch 2 times, most recently from 6f313cd to c9f1101 Compare April 5, 2023 12:08

lpinca reviewed Apr 5, 2023

View reviewed changes

marco-ippolito force-pushed the feat/automate-zlib-update branch from c9f1101 to 210c3bd Compare April 6, 2023 08:00

marco-ippolito requested review from lpinca, ShogunPanda and RafaelGSS April 7, 2023 08:58

ShogunPanda approved these changes Apr 7, 2023

View reviewed changes

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2023

lpinca approved these changes Apr 7, 2023

View reviewed changes

marco-ippolito force-pushed the feat/automate-zlib-update branch 2 times, most recently from b02200c to ef67324 Compare April 11, 2023 14:23

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 12, 2023

marco-ippolito force-pushed the feat/automate-zlib-update branch from ef67324 to 7194af1 Compare April 12, 2023 13:28

RafaelGSS approved these changes Apr 15, 2023

View reviewed changes

tools: automate zlib update

4c1a1a5

marco-ippolito force-pushed the feat/automate-zlib-update branch from 7194af1 to 4c1a1a5 Compare April 17, 2023 07:23

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 17, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 17, 2023

marco-ippolito removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 18, 2023

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 18, 2023

mhdawson approved these changes Apr 18, 2023

View reviewed changes

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 19, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2023

nodejs-github-bot merged commit 8f879de into nodejs:main Apr 19, 2023

marco-ippolito mentioned this pull request May 2, 2023

Dependency update automation improvements nodejs/security-wg#973

Closed

9 tasks

targos mentioned this pull request May 2, 2023

v20.1.0 release proposal #47820

Merged

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: automate zlib update #47417

tools: automate zlib update #47417

marco-ippolito commented Apr 5, 2023 •

edited

Loading

nodejs-github-bot commented Apr 5, 2023

lpinca Apr 5, 2023

marco-ippolito Apr 5, 2023

lpinca Apr 5, 2023 •

edited

Loading

mhdawson Apr 18, 2023

lpinca Apr 18, 2023

marco-ippolito Apr 18, 2023

ShogunPanda left a comment

nodejs-github-bot commented Apr 12, 2023

RafaelGSS left a comment

nodejs-github-bot commented Apr 17, 2023

nodejs-github-bot commented Apr 18, 2023

mhdawson left a comment

nodejs-github-bot commented Apr 19, 2023


		CURRENT_VERSION=$(grep "#define ZLIB_VERSION" "$DEPS_DIR/zlib/zlib.h" \| sed -n "s/^.VERSION \"\(.\)\"/\1/p")

		NEW_VERSION_ZLIB_H=$(curl -s "https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/zlib/zlib.h?format=TEXT" \| base64 --decode)

tools: automate zlib update #47417

tools: automate zlib update #47417

Conversation

marco-ippolito commented Apr 5, 2023 • edited Loading

nodejs-github-bot commented Apr 5, 2023

lpinca Apr 5, 2023

Choose a reason for hiding this comment

marco-ippolito Apr 5, 2023

Choose a reason for hiding this comment

lpinca Apr 5, 2023 • edited Loading

Choose a reason for hiding this comment

mhdawson Apr 18, 2023

Choose a reason for hiding this comment

lpinca Apr 18, 2023

Choose a reason for hiding this comment

marco-ippolito Apr 18, 2023

Choose a reason for hiding this comment

ShogunPanda left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Apr 12, 2023

RafaelGSS left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Apr 17, 2023

nodejs-github-bot commented Apr 18, 2023

mhdawson left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Apr 19, 2023

marco-ippolito commented Apr 5, 2023 •

edited

Loading

lpinca Apr 5, 2023 •

edited

Loading