test: use newish OpenSSL feature in test-tls-dhe #46708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the comment that is being replaced here, this was not possible with the current version of OpenSSL 1.0.2 at the time the test was written. New OpenSSL versions appear to always print the length of the temporary key. Refs: nodejs/node-v0.x-archive#8272
tniessen
added
tls
panva
added
author ready
panva
approved these changes
Feb 18, 2023
panva
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Feb 18, 2023
lpinca
approved these changes
Feb 18, 2023
jasnell
approved these changes
Feb 20, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in c203921 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
According to the comment that is being replaced here, this was not possible with the current version of OpenSSL 1.0.2 at the time the test was written. New OpenSSL versions appear to always print the length of the temporary key. Refs: nodejs/node-v0.x-archive#8272 PR-URL: #46708 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
According to the comment that is being replaced here, this was not possible with the current version of OpenSSL 1.0.2 at the time the test was written. New OpenSSL versions appear to always print the length of the temporary key. Refs: nodejs/node-v0.x-archive#8272 PR-URL: #46708 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comment that is being replaced here, this was not possible with the current version of OpenSSL 1.0.2 at the time the test was written. New OpenSSL versions appear to always print the length of the temporary key.
Refs: nodejs/node-v0.x-archive#8272