lib: cache parsed source maps to reduce memory footprint

[legendecas]

This also improves performance to map the stack trace when the Error.stack is accessed.

                                                      confidence improvement accuracy (*)   (**)  (***)
es/error-stack.js n=100000 method='sourcemap'                ***     18.90 %       ±1.54% ±2.06% ±2.68%
es/error-stack.js n=100000 method='without-sourcemap'                -0.24 %       ±1.40% ±1.86% ±2.43%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

Fixes #46140.

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1292/

Results

                                                      confidence improvement accuracy (*)   (**)  (***)
es/error-stack.js n=100000 method='sourcemap'                ***     18.20 %       ±2.28% ±3.04% ±3.96%
es/error-stack.js n=100000 method='without-sourcemap'                 1.24 %       ±3.05% ±4.06% ±5.29%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 2 comparisons, you can thus
expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49005/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49008/

[bnoordhuis]

LGTM but I'm somewhat baffled by that ObjectGetValueSafe() function. What's its purpose?

If it's to protect against someone users monkey-patching Object.prototype, wouldn't it be better/simpler/more efficient to use symbols instead of named properties?

[nodejs-github-bot]

Landed in 651c09c

[legendecas]

LGTM but I'm somewhat baffled by that ObjectGetValueSafe() function. What's its purpose?

If it's to protect against someone users monkey-patching Object.prototype, wouldn't it be better/simpler/more efficient to use symbols instead of named properties?

Thanks for pointing this out. I'll submit a follow-up PR to make those plain objects to be null-prototyped so that we can get rid of ObjectGetValueSafe.

[joelmukuthu]

Hi all, I see this has so far only been released in v19.6.0. What's the process to get it released on the v18 branch? FYI there's still an active bug in v18 that this fix attempts to address.

[juanarbol]

This uses getCjsSourceMapCache, which was introduced in #45849 and labeled as backport-blocked-v18.x