Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: inherit JOBS from environment #4495

Merged
merged 1 commit into from
Dec 31, 2015

Conversation

jbergstroem
Copy link
Member

In some virtualized environments the amount of available resources are misleading; for instance multiprocessing.cpu_count() on our current 4-core smartos vm's returns 48. This is not a bug, merely how the vm host provides information about available hardware.

Avoid running into issues by overriding cpu_count() with JOBS.

Refs #4494.

@jbergstroem
Copy link
Member Author

/R=the never sleeping @Trott or perhaps @nodejs/build.

CI: https://ci.nodejs.org/job/node-test-commit/1591/

@jbergstroem jbergstroem added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Dec 31, 2015
@jbergstroem
Copy link
Member Author

CI with -J enabled for most (-arm -win) platforms: https://ci.nodejs.org/job/node-test-commit/1592/

@jbergstroem jbergstroem added the smartos Issues and PRs related to the SmartOS platform. label Dec 31, 2015
@mscdex
Copy link
Contributor

mscdex commented Dec 31, 2015

LGTM

@jbergstroem
Copy link
Member Author

..and here we are; the first all-green on -J SmartOS:

screen shot 2015-12-31 at 6 19 32 pm

..as a side note; we've now reduced the test time on smartos by 30% (~15m -> ~10m). Figuring out the rest lives in nodejs/build#293

@jbergstroem
Copy link
Member Author

Unrelated fail on first CI run (which shouldn't be affected by this) and a few – other – fails on the -J runs. At least SmartOS is now green 👏. Will merge shortly.

In some virtualized environments the amount of available resources
are misleading; for instance `multiprocessing.cpu_count()` on our current
4-core smartos vm's returns `48`. This is not a bug, merely how the vm
host provides information about available hardware.

Avoid running into issues by overriding `cpu_count()` with `JOBS`.

PR-URL: nodejs#4495
Reviewed-By: Brian White <mscdex@mscdex.net>
@jbergstroem jbergstroem merged commit 1170b26 into nodejs:master Dec 31, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
In some virtualized environments the amount of available resources
are misleading; for instance `multiprocessing.cpu_count()` on our current
4-core smartos vm's returns `48`. This is not a bug, merely how the vm
host provides information about available hardware.

Avoid running into issues by overriding `cpu_count()` with `JOBS`.

PR-URL: nodejs#4495
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
In some virtualized environments the amount of available resources
are misleading; for instance `multiprocessing.cpu_count()` on our current
4-core smartos vm's returns `48`. This is not a bug, merely how the vm
host provides information about available hardware.

Avoid running into issues by overriding `cpu_count()` with `JOBS`.

PR-URL: #4495
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
In some virtualized environments the amount of available resources
are misleading; for instance `multiprocessing.cpu_count()` on our current
4-core smartos vm's returns `48`. This is not a bug, merely how the vm
host provides information about available hardware.

Avoid running into issues by overriding `cpu_count()` with `JOBS`.

PR-URL: #4495
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
In some virtualized environments the amount of available resources
are misleading; for instance `multiprocessing.cpu_count()` on our current
4-core smartos vm's returns `48`. This is not a bug, merely how the vm
host provides information about available hardware.

Avoid running into issues by overriding `cpu_count()` with `JOBS`.

PR-URL: #4495
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
In some virtualized environments the amount of available resources
are misleading; for instance `multiprocessing.cpu_count()` on our current
4-core smartos vm's returns `48`. This is not a bug, merely how the vm
host provides information about available hardware.

Avoid running into issues by overriding `cpu_count()` with `JOBS`.

PR-URL: nodejs#4495
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants