Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: loosen test for negative timestamps in test-fs-stat-date #44707

Merged

Conversation

LiviaMedeiros
Copy link
Contributor

One more attempt to make test from #43714 pass on v16.x-staging and avoid similar test failures on main in the future.

If filesystem doesn't support negative timestamps and stat returns 0, print a warning and proceed.

cc @targos

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 18, 2022
@LiviaMedeiros LiviaMedeiros added fs Issues and PRs related to the fs subsystem / file system. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Sep 27, 2022

@nodejs/testing @nodejs/fs

@richardlau richardlau mentioned this pull request Oct 7, 2022
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8f8ce25 into nodejs:main Oct 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8f8ce25

juanarbol pushed a commit that referenced this pull request Oct 8, 2022
PR-URL: #44707
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44707
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants