Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improvement dgram.markdown copy #4437

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 27, 2015

General improvements to dgram.markdown copy

@jasnell jasnell added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. labels Dec 27, 2015
@mscdex
Copy link
Contributor

mscdex commented Dec 27, 2015

s/improvement/improvements to/

@jasnell
Copy link
Member Author

jasnell commented Dec 29, 2015

@mscdex ... will update on commit message log either when it lands or when I push additional edits

@Qard
Copy link
Member

Qard commented Dec 29, 2015

Minor, non-blocking nit: It might be clearer to use the term "datagram messages" rather than "datagrams" for the sake of people that are new to UDP/Datagram and not familiar with that terminology.

@nodejs/documentation Thoughts?

Other than that, LGTM.

## Class: dgram.Socket

The dgram Socket class encapsulates the datagram functionality. It
should be created via [`dgram.createSocket(...)`][]
The `dgram.Socket` object is an [`EventEmitter`] that encapsulates the datagram
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you intending on this being a link?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep.. fixing

@jasnell
Copy link
Member Author

jasnell commented Dec 30, 2015

@Qard and @evanlucas ... nits addressed

General improvements to dgram.markdown copy
@JungMinu
Copy link
Member

JungMinu commented Jan 2, 2016

LGTM

jasnell added a commit that referenced this pull request Jan 4, 2016
General improvements to dgram.markdown copy

PR-URL: #4437
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
@jasnell
Copy link
Member Author

jasnell commented Jan 4, 2016

Landed in 7e985d8

@jasnell jasnell closed this Jan 4, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
General improvements to dgram.markdown copy

PR-URL: nodejs#4437
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
jasnell added a commit that referenced this pull request Jan 7, 2016
General improvements to dgram.markdown copy

PR-URL: #4437
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
General improvements to dgram.markdown copy

PR-URL: #4437
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
General improvements to dgram.markdown copy

PR-URL: nodejs#4437
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants