Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused variables from HTTPS tests #4426

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/parallel/test-https-agent-disable-session-reuse.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ if (!common.hasCrypto) {
const TOTAL_REQS = 2;

const https = require('https');
const crypto = require('crypto');

const fs = require('fs');

Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-https-agent-servername.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
var common = require('../common');
var assert = require('assert');

if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-https-byteswritten.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
var common = require('../common');
var assert = require('assert');
var fs = require('fs');
var http = require('http');

if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-eof-for-eom.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ var bodyBuffer = '';

server.listen(common.PORT, function() {
console.log('1) Making Request');
var req = https.get({
https.get({
port: common.PORT,
rejectUnauthorized: false
}, function(res) {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-localaddress-bind-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var server = https.createServer(options, function(req, res) {
});

server.listen(common.PORT, '127.0.0.1', function() {
var req = https.request({
https.request({
host: 'localhost',
port: common.PORT,
path: '/',
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-https-socket-options.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
var common = require('../common');
var assert = require('assert');

if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
Expand All @@ -9,7 +8,6 @@ if (!common.hasCrypto) {
var https = require('https');

var fs = require('fs');
var exec = require('child_process').exec;

var http = require('http');

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-strict.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function makeReq(path, port, error, host, ca) {
path: path,
ca: ca
};
var whichCa = 0;

if (!ca) {
options.agent = agent0;
} else {
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-https-timeout-server-2.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ if (!common.hasCrypto) {
}
var https = require('https');

var net = require('net');
var tls = require('tls');
var fs = require('fs');

Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-https-timeout-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ if (!common.hasCrypto) {
var https = require('https');

var net = require('net');
var tls = require('tls');
var fs = require('fs');

var clientErrors = 0;
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-https-timeout.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
var common = require('../common');
var assert = require('assert');

if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
Expand All @@ -9,7 +8,6 @@ if (!common.hasCrypto) {
var https = require('https');

var fs = require('fs');
var exec = require('child_process').exec;

var options = {
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-https-truncate.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ if (!common.hasCrypto) {
var https = require('https');

var fs = require('fs');
var path = require('path');

var key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
var cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');
Expand Down