Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typo (issue #43766) #43793

Closed
wants to merge 1 commit into from
Closed

Fixing typo (issue #43766) #43793

wants to merge 1 commit into from

Conversation

Arkrez
Copy link

@Arkrez Arkrez commented Jul 12, 2022

Line 14 => "directories; from nghttp3 we only want the contents o the lib." to "directories; from nghttp3 we only want the contents of the lib."

@Arkrez
Fixing typo (issue nodejs#43766)
b643f77 
Line 14 => "directories; from `nghttp3` we only want the contents o the `lib`." to "directories; from `nghttp3` we only want the contents of the `lib`."
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jul 12, 2022
@F3n67u
Copy link
Member

F3n67u commented Jul 12, 2022 •
edited
Loading

Hi @Arkrez thanks for the contribution, but this pr is duplicated with #43767. I am afraid that we will prefer #43767 because it is created first.

@Arkrez
Copy link
Author

Arkrez commented Jul 12, 2022

Sorry, this is my first ever contribution and I'm unfamiliar with how the process goes.

@Arkrez Arkrez closed this Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arkrez @F3n67u @nodejs-github-bot