Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove ETW tool from tier list #43295

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

tony-go
Copy link
Member

@tony-go tony-go commented Jun 2, 2022

Hey 👋 Guess who's back?

Context

The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.

Updated

In the previous instance, we examined the case of the ETW module: issue link.

We decide to remove it, as anyone in the instance has an idea about a potential usage in the field. We prefer to have a list that contains fewer items but is trustable. In case you have a different opinion, please share your thoughts in this PR 🙏.

Discuss

As usual, feel free to share your thoughts on that and your experience with this tool.

With love ❤️

cc @nodejs/diagnostics

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 2, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tniessen
Copy link
Member

tniessen commented Jun 5, 2022

This might need to be rebased for the linter to pass, see #43298.

@tony-go
Copy link
Member Author

tony-go commented Jun 7, 2022

This might need to be rebased for the linter to pass, see #43298.

I'll do it ^^

@lpinca
Copy link
Member

lpinca commented Jun 9, 2022

@tony-go can you please remove the merge commit?

@romulocintra
Copy link

Hi, @tony-go hope this is not too late for the party, we do use ETW in some of our customers as a crucial part of their instrumentation and diagnostic tooling. Not sure if this is enough to keep it on the list nor if there is a minimum requirement for it.

I'm pretty happy to help if you need more details about use cases or anything else that might help.

cc @jdapena @littledan

@tony-go
Copy link
Member Author

tony-go commented Jun 12, 2022

Hi @romulocintra 👋

Thanks for sharing ^^

What we tend to achieve here is more to give a clear picture for newcomers than decide if a tool should be used or not. Then we could delete it for now and put it back later.

I'm happy to help if you need more details about use cases or anything else that might help.

Yeah, for sure:

  • What is the value brought by the tool? And why did you choose it?
  • Which documentation did you use when you decided to use it in a new project?

Also, you can find all the required criteria in the document itself.

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3786ef6 into nodejs:master Jun 13, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3786ef6

danielleadams pushed a commit that referenced this pull request Jun 14, 2022
PR-URL: #43295
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43295
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43295
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43295
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.