win: allow node and io.js to be installed side-by-side #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, as long as we remove that notice about 1.0.[10] within the next month or two |
|
I'll get a nightly out with this change when it's landed |
This allows node.js and io.js to be installed side-by-side. PR: nodejs#431 Reviewed-by: Rod Vagg <rod@vagg.org>
Because the UpgradeCode changes with version 1.0.2, older versions won't be uninstalled automatically. This patch puts a warning in the installer. PR: nodejs#431 Reviewed-by: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@rvagg or @bnoordhuis
@seishun Would be great if you could test this too.