test: add test for tls.parseCertString #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlucas
added
tls
| const assert = require('assert'); | ||
| const tls = require('tls'); | ||
|
|
||
| const singles = 'C=US\nST=CA\nL=SF\nO=Joyent\nOU=Node.js\nCN=ca1\n' |
There was a problem hiding this comment.
s/Joyent/Node.js Foundation/? That also tests if blanks in the O field are parsed correctly.
There was a problem hiding this comment.
Good call. I had copied that directly from the comment above the actual function but will change.
|
LGTM with a suggestion. |
evanlucas
force-pushed
the
parseCertStringTest
branch
from
56865e5
to
7c1a04c
Compare
It does not currently have any explicit tests to verify the behavior. PR-URL: nodejs#4283 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas
force-pushed
the
parseCertStringTest
branch
from
7c1a04c
to
0b9c3a3
Compare
|
Landed in 0b9c3a3. Thanks! |
evanlucas
added a commit
that referenced
this pull request
Dec 15, 2015
It does not currently have any explicit tests to verify the behavior. PR-URL: #4283 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Closed
evanlucas
added a commit
that referenced
this pull request
Dec 30, 2015
It does not currently have any explicit tests to verify the behavior. PR-URL: #4283 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
It does not currently have any explicit tests to verify the behavior. PR-URL: #4283 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
It does not currently have any explicit tests to verify the behavior. PR-URL: nodejs#4283 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not currently have any explicit tests to verify the behavior.