Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add read(buffer[, options]) versions #42768

Merged
merged 16 commits into from
May 2, 2022
Merged

fs: add read(buffer[, options]) versions #42768

merged 16 commits into from
May 2, 2022

Commits on Apr 17, 2022

  1. fs: add read(buffer, options) signatures 

    This adds the following:
`fs.read(fd, buffer[, options], callback)`
`filehandle.read(buffer[, options])`
    @LiviaMedeiros
    LiviaMedeiros committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    c69abaa View commit details
    Browse the repository at this point in the history

  2. squash: make offsetOrOptions more consistent

    @LiviaMedeiros
    LiviaMedeiros committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    aec64ca View commit details
    Browse the repository at this point in the history

  3. squash: add doc entries

    @LiviaMedeiros
    LiviaMedeiros committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    42c9c40 View commit details
    Browse the repository at this point in the history

  4. squash: fix fs.read()

    @LiviaMedeiros
    LiviaMedeiros committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    71f03ce View commit details
    Browse the repository at this point in the history

  5. squash: expand fs-read-optional test

    @LiviaMedeiros
    LiviaMedeiros committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    0bd9de7 View commit details
    Browse the repository at this point in the history

  6. squash: expand fs-read-promises-optional test

    @LiviaMedeiros
    LiviaMedeiros committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    abd6e4f View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. squash: improve tests

    @LiviaMedeiros
    LiviaMedeiros committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9826309 View commit details
    Browse the repository at this point in the history

  2. squash: fixup

    @LiviaMedeiros
    LiviaMedeiros committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    a32c914 View commit details
    Browse the repository at this point in the history

  3. squash: fixup

    @LiviaMedeiros
    LiviaMedeiros committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    6a974c2 View commit details
    Browse the repository at this point in the history

  4. squash: inline null coalescing

    @LiviaMedeiros
    LiviaMedeiros committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    0f586d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. squash: revert changes in fs.readSync()

    @LiviaMedeiros
    LiviaMedeiros committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    6410dec View commit details
    Browse the repository at this point in the history

  2. squash: disallow offset === false

    @LiviaMedeiros
    LiviaMedeiros committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    ccaa4cb View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. squash: fixup

    @LiviaMedeiros
    LiviaMedeiros committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    0e6b06a View commit details
    Browse the repository at this point in the history

  2. squash: allow offset === null

    @LiviaMedeiros
    LiviaMedeiros committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    42b640c View commit details
    Browse the repository at this point in the history

  3. squash: fix tests being other way round

    @LiviaMedeiros
    LiviaMedeiros committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    e153143 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. squash: adjust tests

    @LiviaMedeiros
    LiviaMedeiros committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    ab0b534 View commit details
    Browse the repository at this point in the history