Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve the format-cpp error message #42765

Conversation

RaisinTen
Copy link
Contributor

@RaisinTen RaisinTen commented Apr 17, 2022

This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen raisinten@gmail.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 17, 2022
@RaisinTen RaisinTen force-pushed the build/improve-the-format-cpp-error-message branch from 2e12a44 to d55e95a Compare April 17, 2022 14:51
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen force-pushed the build/improve-the-format-cpp-error-message branch from d55e95a to 25846ac Compare April 17, 2022 14:57
@RaisinTen RaisinTen requested a review from Trott April 17, 2022 14:57
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit fc326d6 into nodejs:master Apr 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in fc326d6

xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs/node#42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants