Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add maintaining-webassembly.md #42660

Closed
wants to merge 5 commits into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Apr 8, 2022

Add maintaining-webassembly.md with startegy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 8, 2022
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
@tniessen
Copy link
Member

tniessen commented Apr 12, 2022

PR to add streaming compilation: #42701

Unfortunately, the spec only allows Response objects so far, but those can be backed by file streams.

@mhdawson
Copy link
Member Author

@tniessen thanks for the PR! Any chance you can review/approve this PR too?

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: there is a typo in the commit message ("strategy").

doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member Author

@tniessen thanks for the review, squashed and fixed the commit comment after pulling in your suggestions.

@mhdawson
Copy link
Member Author

@VoltrexMaster all of your comments should be fixed as well if you want to take another look.

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
doc/contributing/maintaining-web-assembly.md Outdated Show resolved Hide resolved
mhdawson and others added 3 commits April 21, 2022 16:10
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@mhdawson
Copy link
Member Author

@cjihrig many thanks for reviewing.

@mhdawson
Copy link
Member Author

Checks passed and doc only so landing.

mhdawson added a commit that referenced this pull request Apr 21, 2022
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mhdawson
Copy link
Member Author

Landed in 3a6b975

@mhdawson mhdawson closed this Apr 21, 2022
tniessen added a commit to tniessen/node that referenced this pull request Apr 23, 2022
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Apr 25, 2022
Refs: #42660
Refs: #42701

PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
Refs: #42660
Refs: #42701

PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
Refs: #42660
Refs: #42701

PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Refs: #42660
Refs: #42701

PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
Refs: #42660
Refs: #42701

PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #42660
Refs: #42701

PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs/node#42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#42660
Refs: nodejs/node#42701

PR-URL: nodejs/node#42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants