test: use regular timeout times for ARMv8 #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if the CI agrees. |
|
LGTM |
|
LGTM if CI doesn't reveal anything problematic |
|
Good one @Fishrock123, lgtm pending https://ci.nodejs.org/job/node-test-commit/1422/ |
| @@ -245,10 +245,15 @@ exports.platformTimeout = function(ms) { | |||
| if (process.arch !== 'arm') | |||
| return ms; | |||
|
|
|||
| if (process.config.variables.arm_version === '6') | |||
| const armv = process.config.variables.arm_version | |||
|
LGTM. CI seems happy, minus the missing semicolon. |
ARMv8 machines are typically quite fast and likely may not need extended timeout times. PR-URL: nodejs#4248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
force-pushed
the
armv8-timeouts
branch
from
d3200b4
to
668449a
Compare
Fishrock123
added a commit
that referenced
this pull request
Dec 15, 2015
ARMv8 machines are typically quite fast and likely may not need extended timeout times. PR-URL: #4248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
Fishrock123
added a commit
that referenced
this pull request
Dec 30, 2015
ARMv8 machines are typically quite fast and likely may not need extended timeout times. PR-URL: #4248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
ARMv8 machines are typically quite fast and likely may not need extended timeout times. PR-URL: #4248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
ARMv8 machines are typically quite fast and likely may not need extended timeout times. PR-URL: nodejs#4248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARMv8 machines are typically quite fast and likely may not need extended timeout times.
I don't have data on this but I figure it is worth a shot.
cc @nodejs/build