Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,fs: add fs.rm() tests for .git directories #42410

Merged
merged 4 commits into from
Mar 28, 2022
Merged

test,fs: add fs.rm() tests for .git directories #42410

merged 4 commits into from
Mar 28, 2022

Commits on Mar 20, 2022

  1. test,fs: add fs.rm() tests for .git directories 

    Git for Windows creates read-only files inside the .git directory.
fs.rm() was built in a way, to work around any EPERM error that can
happen while deleting the .git directory by turning the directory
into a writable one. This change adds a regression test for that.

Refs: isaacs/rimraf#21
Refs: nodejs#38810 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    7edad00 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. test: check if git is present before running the tests 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b76ef18 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2022

  1. test: run cd dir && git init && cd - instead of git init -C dir 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    a2da073 View commit details
    Browse the repository at this point in the history

  2. fixup! test: run cd dir && git init && cd - instead of `git init -C… 

    … dir`

Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    bc950fa View commit details
    Browse the repository at this point in the history