Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: use SnapshotData to pass snapshot data around #42360

Closed
wants to merge 1 commit into from
Closed

bootstrap: use SnapshotData to pass snapshot data around #42360

wants to merge 1 commit into from

Commits on Mar 16, 2022

  1. bootstrap: use SnapshotData to pass snapshot data around 

    Instead of passing the snapshot blob, the per-isolate data
indices and the EnvSerializeInfo separately, use the aggregate
type Snapshot to carry these around, and refactor
NodeMainInstance so that it owns the v8::Isolate::CreateParams
when it owns its isolate. This also gets rid of the owns_isolate_
and deserialize_mode_ booleans in NodeMainInstance since
NodeMainInstance can compute these by just checking if it has
pointers to the CreateParams or the SnapshotData.
    @joyeecheung
    joyeecheung committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    6c6fa9c View commit details
    Browse the repository at this point in the history