Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: include missing V8 headers in distribution #40526

Closed
wants to merge 1 commit into from
Closed

build: include missing V8 headers in distribution #40526

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 19, 2021 •
edited
Loading

Fixes: nodejs/Release#704
Fixes: #40529

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. labels Oct 19, 2021
@targos targos mentioned this pull request Oct 19, 2021
Closed
@ewanharris ewanharris mentioned this pull request Oct 19, 2021
Closed
@ewanharris
Copy link

ewanharris commented Oct 19, 2021 •
edited
Loading

@targos I think v8-weak-callback-info.h needs adding too based on nodejs/nan/issues/921. Adding the files you've added and v8-weak-callback-info.h manually and I can build the module that uses nan I'm adding Node 17 support too so I think that should then be complete

@kriszyp
Copy link

kriszyp commented Oct 19, 2021 •
edited
Loading

I can also verify that v8-weak-callback-info.h needs to be added to that list (is referenced from v8-persistent-handle.h https://github.com/nodejs/node/blob/master/deps/v8/include/v8-persistent-handle.h#L10), and then I think, at least my code, builds fine.

@wankdanker wankdanker mentioned this pull request Oct 20, 2021
Closed
@targos targos added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 20, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40380/

@Prinzhorn Prinzhorn mentioned this pull request Oct 20, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40381/

@targos
Copy link
Member Author

targos commented Oct 20, 2021

Can I have some reviews? I'd like to make a quick release to fix Node.js native addons.

@richardlau richardlau mentioned this pull request Oct 20, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40385/

@targos
Copy link
Member Author

targos commented Oct 20, 2021 •
edited
Loading

@nodejs/releasers @nodejs/tsc is one of you available to review (and approve fast-tracking)?

mhdawson
mhdawson approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2021
@github-actions
Copy link
Contributor

Landed in a397009...3ec3ba5

@github-actions github-actions bot closed this Oct 20, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2021
@targos @nodejs-github-bot
build: include missing V8 headers in distribution
3ec3ba5 
Fixes: nodejs/Release#704

PR-URL: #40526
Fixes: #40529
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos deleted the fix-v8-install-headers branch October 20, 2021 14:42
targos added a commit that referenced this pull request Oct 20, 2021
@targos
build: include missing V8 headers in distribution
3f03355 
Fixes: nodejs/Release#704

PR-URL: #40526
Fixes: #40529
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos added a commit that referenced this pull request Oct 20, 2021
@targos
2021-10-20, Version 17.0.1 (Current)
d68dd62 
Notable changes:

Fixed distribution for native addon builds

This release fixes an issue introduced in Node.js v17.0.0, where some V8
headers were missing from the distributed tarball, making it impossible
to build native addons. These headers are now included.
#40526

Fixed stream issues
* Fixed a regression in `stream.promises.pipeline`, which was introduced
  in version 16.10.0, is fixed. It is now possible again to pass an
  array of streams to the function.
  #40193
* Fixed a bug in `stream.Duplex.from`, which didn't work properly when
  an async generator function was passed to it.
  #40499

PR-URL: #40535
@targos targos mentioned this pull request Oct 20, 2021
Merged
targos added a commit that referenced this pull request Oct 20, 2021
@targos
2021-10-20, Version 17.0.1 (Current)
73b2d3b 
Notable changes:

Fixed distribution for native addon builds

This release fixes an issue introduced in Node.js v17.0.0, where some V8
headers were missing from the distributed tarball, making it impossible
to build native addons. These headers are now included.
#40526

Fixed stream issues
* Fixed a regression in `stream.promises.pipeline`, which was introduced
  in version 16.10.0, is fixed. It is now possible again to pass an
  array of streams to the function.
  #40193
* Fixed a bug in `stream.Duplex.from`, which didn't work properly when
  an async generator function was passed to it.
  #40499

PR-URL: #40535
@kriszyp kriszyp mentioned this pull request Oct 21, 2021
Closed
@github-actions github-actions bot mentioned this pull request Oct 21, 2021
Open
30 tasks
@Jeve-Stobs Jeve-Stobs mentioned this pull request Oct 21, 2021
Merged
12 tasks
This was referenced Oct 22, 2021
Open
Open
Open
Open
@pedro-w pedro-w mentioned this pull request Nov 8, 2021
Open
@reconbot reconbot mentioned this pull request Nov 8, 2021
Closed
@eight04 eight04 mentioned this pull request Feb 8, 2022
Merged
@MadLittleMods MadLittleMods mentioned this pull request Mar 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing header file v8-weak-callback-info.h in v17 Many missing files in header archive for v17.0.0
6 participants
@targos @ewanharris @kriszyp @nodejs-github-bot @richardlau @mhdawson