meta: consolidate AUTHORS entries for jemjam #40328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
tniessen
approved these changes
Oct 5, 2021
Trott
added
the
author ready
lpinca
approved these changes
Oct 5, 2021
Lxxyx
approved these changes
Oct 6, 2021
PR-URL: nodejs#40328 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
|
Landed in 09e8e14 |
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Oct 8, 2021
PR-URL: nodejs#40328 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure which of the two emails we have for @jemjam was the right one to list in the AUTHORS file, and then saw that there was a third email in their GitHub profile so went with that one.
@jemjam Let me know if you'd prefer to be listed in
AUTHORSwith a different email and I'll update.mailmapin this PR as appropriate.