doc: clarify that priorities applies to values #40318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the discussion on nodejs#40235 it was mentioned that there might be confusion that some of the items listed were technical priorities versus priorities being for the values listed. Tweak to clarify. Signed-off-by: Michael Dawson <mdawson@devrus.com>
tniessen
approved these changes
Oct 5, 2021
jasnell
approved these changes
Oct 7, 2021
|
Doc only change and linters have passed so landing. |
|
Landed in 58739ed |
mhdawson
added a commit
that referenced
this pull request
Oct 7, 2021
In the discussion on #40235 it was mentioned that there might be confusion that some of the items listed were technical priorities versus priorities being for the values listed. Tweak to clarify. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40318 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Oct 8, 2021
In the discussion on nodejs#40235 it was mentioned that there might be confusion that some of the items listed were technical priorities versus priorities being for the values listed. Tweak to clarify. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#40318 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discussion on #40235 it
was mentioned that there might be confusion that some of the
items listed were technical priorities versus priorities
being for the values listed. Tweak to clarify.
Signed-off-by: Michael Dawson mdawson@devrus.com