module,repl: remove repl require() hack #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
util
|
cc @chrisdickinson probably also |
|
LGTM pending the CI |
Remove a hack that was introduced in commit bb6d468 from November 2010. This is groundwork for a follow-up commit that makes it possible to use internal modules in lib/repl.js. PR-URL: nodejs#4026 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Move the method that was added in commit 8ca412b from earlier this month from lib/util.js to lib/internal/util.js. Avoids exposing a method that we may not wish to expose just yet, seeing how it relies on implementation details. PR-URL: nodejs#4026 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bnoordhuis
force-pushed
the
remove-repl-require-hack
branch
from
729b094
to
04b1a2f
Compare
|
should we land this on lts? |
|
I think we should definitely make sure this is stable for a while since it involves the module system. |
This was referenced Dec 8, 2015
Closed
This was referenced Dec 29, 2015
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Jan 7, 2016
Remove a hack that was introduced in commit bb6d468 from November 2010. This is groundwork for a follow-up commit that makes it possible to use internal modules in lib/repl.js. PR-URL: nodejs#4026 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Conflicts: lib/module.js
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Jan 7, 2016
Move the method that was added in commit 8ca412b from earlier this month from lib/util.js to lib/internal/util.js. Avoids exposing a method that we may not wish to expose just yet, seeing how it relies on implementation details. PR-URL: nodejs#4026 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Mar 22, 2022
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll spruce up the commit logs once it's clear this is an approach we want to take.
R=@cjihrig
CI: https://ci.nodejs.org/job/node-test-pull-request/850/