Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in fs #40257

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in fs #40257

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Sep 29, 2021

The original text was "String form" meaning the string form of a path compared to other forms like a Buffer or URL object (as alluded to in the previous paragraph) was correct, however leaving "form" out entirely is slightly better and may confuse people less.

@mscdex mscdex added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 29, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @mscdex. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2021
@github-actions
Copy link
Contributor

Landed in 5607de8...1798674

@github-actions github-actions bot closed this Sep 29, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 29, 2021
PR-URL: #40257
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mscdex mscdex deleted the doc-fs-fix-typo branch September 29, 2021 17:18
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40257
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants