Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark cluster-net-send test flaky on windows #4006

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 24, 2015

See #3957 for details and examples
failures.

Ref: #3957

@Trott
Copy link
Member Author

Trott commented Nov 24, 2015

@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Nov 24, 2015
@bnoordhuis
Copy link
Member

LGTM although I'd like it if we understood better why the test is so flaky on Windows.

Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2015
See nodejs#3957 for details and examples
failures.

Ref: nodejs#3957
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#4006
@Trott
Copy link
Member Author

Trott commented Nov 25, 2015

Landed in 16db4c4

@Trott Trott closed this Nov 25, 2015
Trott added a commit that referenced this pull request Dec 1, 2015
See #3957 for details and examples
failures.

Ref: #3957
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #4006
Trott added a commit that referenced this pull request Dec 4, 2015
See #3957 for details and examples
failures.

Ref: #3957
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #4006
Trott added a commit that referenced this pull request Dec 5, 2015
See #3957 for details and examples
failures.

Ref: #3957
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #4006
@jasnell jasnell mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 17, 2015
See #3957 for details and examples
failures.

Ref: #3957
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #4006
Trott added a commit that referenced this pull request Dec 23, 2015
See #3957 for details and examples
failures.

Ref: #3957
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #4006
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
See nodejs#3957 for details and examples
failures.

Ref: nodejs#3957
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#4006
@Trott Trott deleted the send-flaky branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants