Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: use validators for consistency #39812

Closed
wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

The usage of more validators could clean up validation and keep
consistency.

@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. labels Aug 19, 2021
@VoltrexKeyva VoltrexKeyva changed the title lib: use validators for consistency console: use validators for consistency Aug 19, 2021
The usage of more validators could clean up validation and keep
consistency.
@Ayase-252 Ayase-252 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 23, 2021

@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 23, 2021
@jasnell
Copy link
Member

jasnell commented Sep 25, 2021

Landed in 4157317

@jasnell jasnell closed this Sep 25, 2021
jasnell pushed a commit that referenced this pull request Sep 25, 2021
The usage of more validators could clean up validation and keep
consistency.

PR-URL: #39812
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@VoltrexKeyva VoltrexKeyva deleted the patch-9 branch September 25, 2021 14:53
targos pushed a commit that referenced this pull request Oct 4, 2021
The usage of more validators could clean up validation and keep
consistency.

PR-URL: #39812
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants