Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: use validateArray #39774

Closed
wants to merge 1 commit into from
Closed

Conversation

VoltrexKeyva
Copy link
Member

The validateArray() validator could be used to cleanup validation
and keep consistency.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Aug 15, 2021
The `validateArray()` validator could be used to cleanup validation
and keep consistency.
@VoltrexKeyva VoltrexKeyva added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 3, 2021
@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 23, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Sep 26, 2021
@Ayase-252 Ayase-252 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2021
@github-actions
Copy link
Contributor

Landed in b25a73f...256fe21

@github-actions github-actions bot closed this Sep 26, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 26, 2021
The `validateArray()` validator could be used to cleanup validation
and keep consistency.

PR-URL: #39774
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@VoltrexKeyva VoltrexKeyva deleted the patch-3 branch September 26, 2021 12:59
targos pushed a commit that referenced this pull request Oct 4, 2021
The `validateArray()` validator could be used to cleanup validation
and keep consistency.

PR-URL: #39774
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants