Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify module loading behavior #3920

Closed
wants to merge 0 commits into from
Closed

doc: clarify module loading behavior #3920

wants to merge 0 commits into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 19, 2015

The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873

@cjihrig cjihrig mentioned this pull request Nov 19, 2015
Closed
@jasnell
Copy link
Member

jasnell commented Nov 19, 2015

LGTM

@jasnell jasnell added doc Issues and PRs related to the documentations. lts-watch-v4.x labels Nov 19, 2015
@targos
Copy link
Member

targos commented Nov 19, 2015

LGTM

@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Nov 19, 2015
cjihrig added a commit that referenced this pull request Nov 19, 2015
@cjihrig
doc: clarify module loading behavior
5900d14 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@cjihrig cjihrig closed this Nov 19, 2015
@cjihrig cjihrig deleted the lookup-docs branch November 19, 2015 18:12
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
Closed
cjihrig added a commit that referenced this pull request Dec 1, 2015
@cjihrig
doc: clarify module loading behavior
ebf072a 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
cjihrig added a commit that referenced this pull request Dec 4, 2015
@cjihrig @rvagg
doc: clarify module loading behavior
13e8b84 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
cjihrig added a commit that referenced this pull request Dec 5, 2015
@cjihrig @rvagg
doc: clarify module loading behavior
bbcb2a2 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
cjihrig added a commit that referenced this pull request Dec 17, 2015
@cjihrig @jasnell
doc: clarify module loading behavior
4bc71e0 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
cjihrig added a commit that referenced this pull request Dec 23, 2015
@cjihrig @jasnell
doc: clarify module loading behavior
ad02f0e 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @jasnell @targos @mscdex @MylesBorins