Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix typos #38845

Merged
merged 1 commit into from
Jun 1, 2021
Merged

src: fix typos #38845

merged 1 commit into from
Jun 1, 2021

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented May 29, 2021 •
edited
Loading

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 29, 2021
@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 31, 2021
@bl-ue @aduh95
src: fix typos
11e77e4 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@aduh95
Copy link
Contributor

aduh95 commented Jun 1, 2021

Landed in 11e77e4

@aduh95 aduh95 merged commit 11e77e4 into nodejs:master Jun 1, 2021
@bl-ue bl-ue deleted the fix-src-typos branch June 1, 2021 12:23
@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 1, 2021 •
edited
Loading

GH says the PR was merged, not closed. @aduh95 any idea why?

danielleadams pushed a commit that referenced this pull request Jun 1, 2021
@bl-ue @danielleadams
src: fix typos
f25cd4f 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@danielleadams danielleadams mentioned this pull request Jun 1, 2021
Merged
@aduh95
Copy link
Contributor

aduh95 commented Jun 1, 2021

GH says the PR was merged, not closed. @aduh95 any idea why?

I force-pushed the amended commit to your branch before pushing it to master so the GitHub UI shows merged status. Sorry if that's an inconvenience for you, FYI you can disable this by unchecking Allow edits and access to secrets by maintainers when creating the PR.

@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 1, 2021

Ah, I see! That makes sense. I guess it's not as nice for the PRs history...but I do like seeing that the PR was merged (because GH saying that it was closed is quite confusing...)

I'll leave that checkbox alone and let you guys keep merging how you like—I don't care much one way or another.

richardlau pushed a commit that referenced this pull request Jul 16, 2021
@bl-ue @richardlau
src: fix typos
cbdef7d 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@bl-ue @richardlau
src: fix typos
b6acc51 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@bl-ue @richardlau
src: fix typos
73e199d 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@bl-ue @foxxyz
src: fix typos
2eaf123 
PR-URL: nodejs#38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@antsmartian antsmartian antsmartian approved these changes

@cjihrig cjihrig cjihrig approved these changes

@XadillaX XadillaX XadillaX approved these changes

@himself65 himself65 himself65 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bl-ue @aduh95 @jasnell @Trott @addaleax @antsmartian @cjihrig @XadillaX @himself65 @RaisinTen