test: move test-specific function out of common #3871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common.checkSpawnSyncRet is only used in one test. Move it out of common.js and into that test (test-child-process-spawnsync-input.js).
|
LGTM |
mscdex
added
the
child_process
Trott
added a commit
that referenced
this pull request
Nov 17, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of common.js and into that test (test-child-process-spawnsync-input.js). PR-URL: #3871 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in b385772 |
Trott
added a commit
that referenced
this pull request
Nov 17, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of common.js and into that test (test-child-process-spawnsync-input.js). PR-URL: #3871 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
that referenced
this pull request
Dec 1, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of common.js and into that test (test-child-process-spawnsync-input.js). PR-URL: #3871 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
that referenced
this pull request
Dec 4, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of common.js and into that test (test-child-process-spawnsync-input.js). PR-URL: #3871 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
Trott
added a commit
that referenced
this pull request
Dec 17, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of common.js and into that test (test-child-process-spawnsync-input.js). PR-URL: #3871 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
that referenced
this pull request
Dec 23, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of common.js and into that test (test-child-process-spawnsync-input.js). PR-URL: #3871 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.checkSpawnSyncRet()is only used in one test. Move it out ofcommon.jsand into that test (test-child-process-spawnsync-input.js).