test: fix flaky test-net-server-max-connections test on SmartOS #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmartOS has an issue where it will trigger ECONNREFUSED when it should not. See https://smartos.org/bugview/OS-2767. This change adds logic to test-net-server-max-connections.js to work around the issue. Fixes: nodejs#2663
|
@Trott ... there's a CI failure on smartos. Can you see if it's related? |
|
@jasnell The SmartOS failure in the CI is unrelated to the code changes here. It's in a different test. (But it does appear as if it is likely caused by the same SmartOS issue. I might see about coding up a separate workaround for that test and submitting that in a separate PR.) EDIT: Actually, I've run the other test a few hundred times on SmartOS and can't get the unrelated test failure to crop up again, so I'm inclined to ignore it unless/until it shows up again on CI. |
|
Ok. LGTM! |
|
Related but not anything that should stop this from landing: Running https://ci.nodejs.org/job/node-stress-single-test/3/ to see if that other test is flaky or not. If so, I'll try to fix that different test in a different PR. |
|
Landed in 5b80ca9 |
Trott
added a commit
that referenced
this pull request
Nov 16, 2015
SmartOS has an issue where it will trigger ECONNREFUSED when it should not. See https://smartos.org/bugview/OS-2767. This change adds logic to test-net-server-max-connections.js to work around the issue. Fixes: #2663 PR-URL: #3830 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
that referenced
this pull request
Nov 17, 2015
SmartOS has an issue where it will trigger ECONNREFUSED when it should not. See https://smartos.org/bugview/OS-2767. This change adds logic to test-net-server-max-connections.js to work around the issue. Fixes: #2663 PR-URL: #3830 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
that referenced
this pull request
Nov 30, 2015
SmartOS has an issue where it will trigger ECONNREFUSED when it should not. See https://smartos.org/bugview/OS-2767. This change adds logic to test-net-server-max-connections.js to work around the issue. Fixes: #2663 PR-URL: #3830 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
that referenced
this pull request
Dec 4, 2015
SmartOS has an issue where it will trigger ECONNREFUSED when it should not. See https://smartos.org/bugview/OS-2767. This change adds logic to test-net-server-max-connections.js to work around the issue. Fixes: #2663 PR-URL: #3830 Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
Trott
added a commit
that referenced
this pull request
Dec 17, 2015
SmartOS has an issue where it will trigger ECONNREFUSED when it should not. See https://smartos.org/bugview/OS-2767. This change adds logic to test-net-server-max-connections.js to work around the issue. Fixes: #2663 PR-URL: #3830 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
that referenced
this pull request
Dec 23, 2015
SmartOS has an issue where it will trigger ECONNREFUSED when it should not. See https://smartos.org/bugview/OS-2767. This change adds logic to test-net-server-max-connections.js to work around the issue. Fixes: #2663 PR-URL: #3830 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmartOS has an issue where it will trigger ECONNREFUSED when it should
not. See https://smartos.org/bugview/OS-2767.
This change adds logic to test-net-server-max-connections.js to work
around the issue.
Fixes: #2663