Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 4.6.85.31 #3698

Merged
merged 1 commit into from
Nov 11, 2015
Merged

deps: update V8 to 4.6.85.31 #3698

merged 1 commit into from
Nov 11, 2015

Conversation

targos
Copy link
Member

@targos targos commented Nov 6, 2015

This update contains the patch floated in
#3390 and a fix for
Intl.NumberFormat.

Diff: https://chromium.googlesource.com/v8/v8.git/+/4.6.85.28..4.6.85.31

cc @nodejs/v8

@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Nov 6, 2015
@bnoordhuis
Copy link
Member

LGTM

@targos
Copy link
Member Author

targos commented Nov 6, 2015

@JungMinu
Copy link
Member

JungMinu commented Nov 7, 2015

LGTM

@targos
Copy link
Member Author

targos commented Nov 10, 2015

New CI because there were a lot of failures on Windows: https://ci.nodejs.org/job/node-test-commit/1071/

@targos targos mentioned this pull request Nov 10, 2015
@ofrobots
Copy link
Contributor

LGTM.

@bnoordhuis
Copy link
Member

A flake on one of the Windows buildbots but otherwise green. I'd say it's ready to land.

This update contains the patch floated in
nodejs#3390 and a fix for
Intl.NumberFormat.

Diff: https://chromium.googlesource.com/v8/v8.git/+/4.6.85.28..4.6.85.31

PR-URL: nodejs#3698
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@targos targos merged commit 2930867 into nodejs:master Nov 11, 2015
@targos targos deleted the update-v8 branch November 11, 2015 07:24
@targos
Copy link
Member Author

targos commented Nov 11, 2015

landed in 2930867

targos added a commit that referenced this pull request Nov 11, 2015
This update contains the patch floated in
#3390 and a fix for
Intl.NumberFormat.

Diff: https://chromium.googlesource.com/v8/v8.git/+/4.6.85.28..4.6.85.31

PR-URL: #3698
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
@rvagg rvagg mentioned this pull request Dec 17, 2015
@lewispham lewispham mentioned this pull request Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants