Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update lts description in the collaborator guide #3668

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 5, 2015

Update description of the LTS process in the collaborators guide based on the
current practice. @nodejs/lts

@jasnell jasnell added doc Issues and PRs related to the documentations. lts Issues and PRs related to Long Term Support releases. labels Nov 5, 2015
@jasnell jasnell self-assigned this Nov 5, 2015
documentation updates, and certain performance improvements that can be
demonstrated to not break existing applications. Semver-minor changes are only
permitted if required for bug fixes and then only on a case-by-case basis with
LTS WG and possibly TSC review. Semver-major changes are only permitted if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSC -> CTC

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. I'm gonna start just using random letters instead

@jasnell
Copy link
Member Author

jasnell commented Nov 5, 2015

@trevnorris ... updated. PTAL

@jasnell
Copy link
Member Author

jasnell commented Nov 9, 2015

@nodejs/lts ... ping


Once a stable branch moves into Maintenance mode, only **critical** bugs, **critical** security fixes,
and documentation updates will be permitted.
Once a stable branch enters LTS, no new features may be added to that release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that true? It seems that it's a bit more subtle than that. See #3609 for instance. It seems that the text below:

Semver-minor changes are only permitted if required for bug fixes and then only on a case-by-case basis with LTS WG and possibly Core Technical Committee (CTC) review.

actually describes this subtle situation better, and that that phrase might actually not be needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Missed that one :-) Will fix!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@misterdjules
Copy link

@jasnell Added some comments.

@jasnell
Copy link
Member Author

jasnell commented Nov 10, 2015

@misterdjules ... updated to fix the first comment (#3668 (comment))

@misterdjules
Copy link

@jasnell LGTM, thank you!

jasnell added a commit that referenced this pull request Nov 11, 2015
PR-URL: #3668
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
@jasnell
Copy link
Member Author

jasnell commented Nov 11, 2015

Landed in dac387e

@jasnell jasnell closed this Nov 11, 2015
jasnell added a commit that referenced this pull request Nov 13, 2015
PR-URL: #3668
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
jasnell added a commit that referenced this pull request Nov 17, 2015
PR-URL: #3668
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
@MylesBorins
Copy link
Contributor

landed in v4.x-staging in 9970b76

jasnell added a commit that referenced this pull request Dec 4, 2015
PR-URL: #3668
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
@jasnell jasnell mentioned this pull request Dec 17, 2015
jasnell added a commit that referenced this pull request Dec 17, 2015
PR-URL: #3668
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
jasnell added a commit that referenced this pull request Dec 23, 2015
PR-URL: #3668
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. lts Issues and PRs related to Long Term Support releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants