Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: redirect stderr EnvironmentWithNoESMLoader #36548

Merged
merged 1 commit into from
Dec 24, 2020

Commits on Dec 24, 2020

  1. test: redirect stderr EnvironmentWithNoESMLoader

    This commit adds a suggestion to redirect stderr for
    EnvironmentTest.EnvironmentWithNoESMLoader.
    
    The motivation for this is that currently this tests prints the
    following error (which is expected):
    
    vm:module(0):1
    globalThis.importResult = import("")
    ^
    
    Error: Not supported
     at vm:module(0):1:1
     at SourceTextModule.evaluate (node:internal/vm/module:229:23)
     at node:embedder_main_12:1:328
     at processTicksAndRejections (node:internal/process/task_queues:93:5)
    
    It might not be obvious which test caused this error just by looking at
    the output above and it would be nice if it was not displayed.
    
    PR-URL: nodejs#36548
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    danbev authored and Trott committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    3b0ecfc View commit details
    Browse the repository at this point in the history