Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: simplify worker_threads.md text #36545

Merged
merged 1 commit into from
Dec 21, 2020
Merged

doc: simplify worker_threads.md text #36545

merged 1 commit into from
Dec 21, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 17, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Dec 17, 2020
Lxxyx
Lxxyx approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@Lxxyx Lxxyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's easier to understand.

mhdawson
mhdawson approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
doc: simplify worker_threads.md text
b5fdb9e 
PR-URL: nodejs#36545
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@Trott Trott merged commit b5fdb9e into nodejs:master Dec 21, 2020
@Trott
Copy link
Member Author

Trott commented Dec 21, 2020

Landed in b5fdb9e

@Trott Trott deleted the wt-revise branch December 21, 2020 13:45
targos pushed a commit that referenced this pull request Dec 21, 2020
@Trott @targos
doc: simplify worker_threads.md text
c5602fb 
PR-URL: #36545
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Sep 13, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Sep 13, 2022
Open
This was referenced Sep 13, 2022
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 13, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Sep 14, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @lpinca @mhdawson @Lxxyx @targos @nodejs-github-bot