Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove duplicate V macros in node_v8.cc #36454

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Dec 9, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. labels Dec 9, 2020
@danbev danbev added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2020
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Dec 11, 2020

Looks like this accidentally includes a2a2ff3?

@danbev
Copy link
Contributor Author

danbev commented Dec 11, 2020

Looks like this accidentally includes a2a2ff3?

Thanks for pointing that out, I did not notice. I'll update this shortly.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@nodejs-github-bot
Copy link
Collaborator

@danbev
Copy link
Contributor Author

danbev commented Dec 14, 2020

Re-run of failing node-test-commit-linux-containered ✔️
Re-run of failing node-test-commit-arm-fanned ✔️

danbev added a commit that referenced this pull request Dec 14, 2020
PR-URL: #36454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented Dec 14, 2020

Landed in 903998a.

@danbev danbev closed this Dec 14, 2020
@danbev danbev deleted the node_v8_macros branch December 14, 2020 07:46
targos pushed a commit that referenced this pull request Dec 21, 2020
PR-URL: #36454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants