Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domains: emit uncaughtException when appropriate #3638

Closed
wants to merge 2 commits into from

Conversation

misterdjules
Copy link

Fix node exiting due to an exception being thrown rather than emitting
an 'uncaughtException' event on the process object when no error
handler is set on the domain within which an error is thrown and an
'uncaughtException' event listener is set on the process.

Fixes #3607.

/cc @nodejs/lts @nodejs/tsc @nodejs/collaborators

@misterdjules misterdjules added domain Issues and PRs related to the domain subsystem. v0.12 labels Nov 3, 2015
* given test tests one of these potentially eroneous behaviors that are
* currently accepted as correct.
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require common please

@misterdjules misterdjules force-pushed the fix-issue-3607-v0-12 branch 3 times, most recently from 5a8cc6b to 7dd903f Compare November 3, 2015 06:44
@jasnell
Copy link
Member

jasnell commented Nov 3, 2015

@misterdjules ... just a quick note: we'll want to land this in v0.12-staging first. Per the LTS WG discussion on monday, we're going to try use the -staging branches to help organize the LTS releases from v4.x, v0.12 and v0.10 going forward.

@misterdjules
Copy link
Author

@jasnell Sounds good.

@jbergstroem
Copy link
Member

Julien Gilli added 2 commits November 4, 2015 12:49
Fix node exiting due to an exception being thrown rather than emitting
an `'uncaughtException'` event on the process object when no error
handler is set on the domain within which an error is thrown and an
`'uncaughtException'` event listener is set on the process.

Fixes nodejs#3607.
Make the process abort if an error is thrown within a domain with no
error handler and `--abort-on-uncaught-exception` is used.

If the domain within which the error is thrown has no error handler,
but a domain further down the domains stack has one, the process will
not abort.

Fixes nodejs#3653
@misterdjules
Copy link
Author

@jbergstroem Thank you for running the tests on this. I think the correct link to the CI results is https://ci.nodejs.org/job/node-test-commit/1040/.

Anyway, I needed to run tests again because since then I updated this PR with a new commit. CI running here: https://ci.nodejs.org/job/node-test-pull-request/677/.

@misterdjules
Copy link
Author

Closing in favor of #3885.

@misterdjules misterdjules deleted the fix-issue-3607-v0-12 branch July 24, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Issues and PRs related to the domain subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants