Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document rmdir/recursive deprecation #35579

Closed
wants to merge 5 commits into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 9, 2020

Document deprecation of rmdir/recursive permissive functionality.


As suggested by @aduh95, this adds the deprecation of the permissive behavior of rmdir/recursive as a docs only deprecation, in the deprecations.md.

We already updated the docs in #35171, to mention that the permissive behavior will one day be removed.

Refs: #35562

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

CC: @iansu

Document deprecation of rmdir/recursive permissive functionality
@bcoe bcoe requested review from Trott, BridgeAR and aduh95 October 9, 2020 22:05
@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Oct 9, 2020
doc/api/deprecations.md Outdated Show resolved Hide resolved
doc/api/deprecations.md Outdated Show resolved Hide resolved
bcoe and others added 2 commits October 9, 2020 18:10
Co-authored-by: Anna Henningsen <github@addaleax.net>
@bcoe bcoe requested review from addaleax and Trott October 10, 2020 01:18
@nodejs-github-bot

This comment has been minimized.

@bcoe bcoe added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2020
@nodejs-github-bot
Copy link
Collaborator

bcoe added a commit that referenced this pull request Oct 12, 2020
Document deprecation of rmdir/recursive permissive functionality

PR-URL: #35579
Refs: #35562
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@bcoe
Copy link
Contributor Author

bcoe commented Oct 12, 2020

Landed in c759281

@bcoe bcoe closed this Oct 12, 2020
@bcoe bcoe deleted the document-rmdir-recurse-deprecation branch October 12, 2020 16:46
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
Document deprecation of rmdir/recursive permissive functionality

PR-URL: #35579
Refs: #35562
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Document deprecation of rmdir/recursive permissive functionality

PR-URL: nodejs#35579
Refs: nodejs#35562
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Aug 12, 2021
PR-URL: #39728
Refs: #35579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39728
Refs: #35579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39728
Refs: #35579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants