Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: replace "you should do X" with "do X" #35194

Merged
merged 1 commit into from
Sep 16, 2020
Merged

doc: replace "you should do X" with "do X" #35194

merged 1 commit into from
Sep 16, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 14, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Sep 14, 2020
@Trott
doc: replace "you should do X" with "do X"
18462e0 
PR-URL: nodejs#35194
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott merged commit 18462e0 into nodejs:master Sep 16, 2020
@Trott Trott deleted the you-should branch September 16, 2020 20:26
@Trott
Copy link
Member Author

Trott commented Sep 16, 2020

Landed in 18462e0

ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
@Trott @ruyadorno
doc: replace "you should do X" with "do X"
70ec369 
PR-URL: #35194
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: replace "you should do X" with "do X"
3ffaf66 
PR-URL: #35194
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: replace "you should do X" with "do X"
c6d74ac 
PR-URL: nodejs#35194
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@wedataintelligence wedataintelligence mentioned this pull request Nov 30, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 30, 2023
Open
@baby636 baby636 mentioned this pull request Dec 1, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2024
Open
@molllyn1 molllyn1 mentioned this pull request May 13, 2024
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2024
Open
@137717unity 137717unity mentioned this pull request May 14, 2024
Open
@baby636 baby636 mentioned this pull request May 14, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request May 14, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @addaleax @targos @nodejs-github-bot