doc: fix deprecation documentation inconsistencies #35082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/documentation |
Trott
approved these changes
Sep 16, 2020
Trott
force-pushed
the
fix-deprecation-inconsistencies
branch
from
b6be744
to
dfa2dad
Compare
|
Landed in dfa2dad |
PR-URL: nodejs#35082 Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 21, 2020
PR-URL: #35082 Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #35082 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35082 Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a few inconsistencies between
deprecations.mdand other doc files:domain.mddoesn't indicate in which version its deprecation was introduced (https://nodejs.org/docs/latest/api/deprecations.html#DEP0032).EventEmitter.listenerCountindicates a deprecation introduced inv4.0.0inevents.md, but it'sv3.2.0according todeprecations.md(https://nodejs.org/docs/latest/api/deprecations.html#DEP0033).fs.lchown[Sync] indicates when its deprecation was revoked, but not when it was assigned infs.md(https://nodejs.org/docs/latest/api/deprecations.html#DEP0037 & https://nodejs.org/docs/latest/api/deprecations.html#DEP0038).punycode.mdindicates a runtime deprecation, but instead it's a documentation-only deprecation (https://nodejs.org/docs/latest/api/deprecations.html#DEP0040).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes