Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix upgrade to npm 3.3.6 #3494

Closed
wants to merge 1 commit into from
Closed

deps: fix upgrade to npm 3.3.6 #3494

wants to merge 1 commit into from

Conversation

iarna
Copy link
Member

@iarna iarna commented Oct 23, 2015

This adds the debug dep back in for npm@3.3.6. I'll PR separately for fixing the .gitigore to not cause this problem again. This will resolve the problem in #3493

@iarna iarna mentioned this pull request Oct 23, 2015
Closed
@jbergstroem
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/924/

Edit: fix CI link.
Edit2: had to cancel and resubmit, link updated.

@jbergstroem jbergstroem added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 23, 2015
@evanlucas
Copy link
Contributor

CI looks good (minus the tests that have been failing pretty consistently lately)

LGTM

@jasnell
Copy link
Member

jasnell commented Oct 23, 2015

LGTM. Will get this landed now so CI can get back on track

jasnell pushed a commit that referenced this pull request Oct 23, 2015
@iarna @jasnell
deps: fix upgrade to npm 3.3.6
68471dd 
41923c0 broke things. This fixes them.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #3494
@jasnell
Copy link
Member

jasnell commented Oct 23, 2015

Landed in 68471dd

@jasnell jasnell closed this Oct 23, 2015
rvagg pushed a commit that referenced this pull request Oct 26, 2015
@iarna @rvagg
deps: fix upgrade to npm 3.3.6
f76af49 
41923c0 broke things. This fixes them.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #3494
This was referenced Oct 27, 2015
Merged
Closed
Closed
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
@MylesBorins MylesBorins mentioned this pull request Jan 14, 2016
Closed
This was referenced Apr 29, 2023
Open
Open
This was referenced Jun 22, 2023
Open
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Jul 9, 2023
Open
@aliscco aliscco mentioned this pull request Oct 27, 2023
Open
@aliscco aliscco mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iarna @jbergstroem @evanlucas @jasnell @rvagg