Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: fix lint error in node_quic_crypto #34019

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 22, 2020

Currently, the following lint error is generated:

Running C++ linter...
File "src/quic/node_quic_crypto.cc" does not use "String"
make[1]: *** [Makefile:1336: tools/.cpplintstamp] Error 1

This commit removes the unused using declaration.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Currently, the following lint error is generated:
Running C++ linter...
File "src/quic/node_quic_crypto.cc" does not use "String"
make[1]: *** [Makefile:1336: tools/.cpplintstamp] Error 1

This commit removes the unused using declaration.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jun 22, 2020
@danbev danbev added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 22, 2020
@danbev
Copy link
Contributor Author

danbev commented Jun 22, 2020

Can we fast-track this?

@jasnell
Copy link
Member

jasnell commented Jun 22, 2020

@jasnell
Copy link
Member

jasnell commented Jun 22, 2020

will land as soon as CI comes back

jasnell pushed a commit that referenced this pull request Jun 22, 2020
Currently, the following lint error is generated:
Running C++ linter...
File "src/quic/node_quic_crypto.cc" does not use "String"
make[1]: *** [Makefile:1336: tools/.cpplintstamp] Error 1

This commit removes the unused using declaration.

PR-URL: #34019
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 22, 2020

Landed in adf14e2

@jasnell jasnell closed this Jun 22, 2020
@danbev danbev deleted the quic-lint-error branch November 5, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants