Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: stronger validation for 'servername' in server.addContext #33943

Closed
wants to merge 5 commits into from

Commits on Jun 18, 2020

  1. tls: stronger validation for 'servername' in server.addContext

    If 'servername' is not provided, 'ERR_MISSING_ARGS is thrown.
    If 'servername' is not a string, 'ERR_INVALID_ARG_TYPE' is thrown.
    If 'servername' is an IP address, 'ERR_INVALID_ARG_VALUE' is thrown, since
    literal IPv4 and IPv6 addresses are not permitted in SNI.
    
    Fixed API documentation ('hostname' -> 'servername').
    
    Also removed a redundant error 'ERR_TLS_REQUIRED_SERVER_NAME'.
    mkrawczuk committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    00b7b9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6532918 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. fixup! correct doc link.

    mkrawczuk committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    38d50aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9149d3b View commit details
    Browse the repository at this point in the history
  3. fixup!

    mkrawczuk committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    cb77037 View commit details
    Browse the repository at this point in the history