Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Changed function to arrow function #33711

Closed
wants to merge 1 commit into from
Closed

Test: Changed function to arrow function #33711

wants to merge 1 commit into from

Conversation

sagar-jadhav
Copy link
Contributor

@sagar-jadhav sagar-jadhav commented Jun 3, 2020

Converted anonymous callback functions to arrow functions for better readability.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Note: Some unrelated tests failed with timeout error on macOS

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 3, 2020
@juanarbol juanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 6, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 6, 2020

Convert callback functions that are anonymous
to arrow functions for better readability.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 6, 2020

juanarbol pushed a commit that referenced this pull request Jun 6, 2020
Convert callback functions that are anonymous
to arrow functions for better readability.

PR-URL: #33711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@juanarbol
Copy link
Member

Landed in 3ac50e1 🎉

Thank you!

@juanarbol juanarbol closed this Jun 6, 2020
@sagar-jadhav sagar-jadhav deleted the arrowfunction branch June 6, 2020 04:01
@sagar-jadhav
Copy link
Contributor Author

3ac50e1

Thank you 👍

codebytere pushed a commit that referenced this pull request Jun 18, 2020
Convert callback functions that are anonymous
to arrow functions for better readability.

PR-URL: #33711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Convert callback functions that are anonymous
to arrow functions for better readability.

PR-URL: #33711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
Convert callback functions that are anonymous
to arrow functions for better readability.

PR-URL: #33711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
Convert callback functions that are anonymous
to arrow functions for better readability.

PR-URL: #33711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants