Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix node.gyp config #33685

Closed
wants to merge 1 commit into from
Closed

Conversation

gengjiawen
Copy link
Member

This lead to weird config bug on windows.

@gengjiawen gengjiawen requested a review from jasnell June 1, 2020 15:47
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 1, 2020
@addaleax
Copy link
Member

addaleax commented Jun 1, 2020

👍 to fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 1, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos self-assigned this Jun 2, 2020
@targos
Copy link
Member

targos commented Jun 2, 2020

Landed in 81f6dd6

targos pushed a commit that referenced this pull request Jun 2, 2020
PR-URL: #33685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos closed this Jun 2, 2020
@gengjiawen gengjiawen deleted the gyp_fix branch June 2, 2020 08:46
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere
Copy link
Member

Backport blocked on #33291

@targos targos removed their assignment Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants