Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: add tests, better toString #33622

Closed
wants to merge 2 commits into from
Closed

events: add tests, better toString #33622

wants to merge 2 commits into from

Conversation

benjamingr
Copy link
Member

Support toStringTag on EventTarget so that our implmentation logs [object EventTarget], add tests to that and a test for subclassing Events.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingr benjamingr requested a review from jasnell May 28, 2020 18:20
@benjamingr benjamingr added the events Issues and PRs related to the events subsystem / EventEmitter. label May 28, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31620/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31638/

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label May 29, 2020
@jasnell
Copy link
Member

jasnell commented May 29, 2020

Fixups to an unreleased experimental internal feature... fast track?

@BridgeAR
Copy link
Member

Landed in 56e4460

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 30, 2020
@benjamingr @BridgeAR
events: add tests, better toString
56e4460 
PR-URL: nodejs#33622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR closed this May 30, 2020
@lundibundi lundibundi mentioned this pull request May 31, 2020
Closed
2 tasks
This was referenced Jun 4, 2020
Closed
Open
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@benjamingr @codebytere
events: add tests, better toString
f3d0d30 
PR-URL: #33622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@benjamingr @codebytere
events: add tests, better toString
2006d60 
PR-URL: #33622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax addaleax mentioned this pull request Sep 22, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benjamingr @nodejs-github-bot @jasnell @BridgeAR @addaleax