Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: assign missing deprecation code #33109

Closed
wants to merge 1 commit into from
Closed

doc: assign missing deprecation code #33109

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Refs: #32807

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@richardlau
doc: assign missing deprecation code
1466aef 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>
@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Apr 27, 2020
@richardlau richardlau mentioned this pull request Apr 27, 2020
Merged
addaleax
addaleax approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 27, 2020
addaleax pushed a commit that referenced this pull request Apr 27, 2020
@richardlau @addaleax
doc: assign missing deprecation code
76ba950 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@addaleax
Copy link
Member

Landed in 76ba950

@addaleax addaleax closed this Apr 27, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@richardlau @BethGriggs
doc: assign missing deprecation code
00c3ed9 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@richardlau @BridgeAR
doc: assign missing deprecation code
fc9191a 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@richardlau @BridgeAR
doc: assign missing deprecation code
386d158 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@richardlau @BethGriggs
doc: assign missing deprecation code
fa5848e 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@richardlau @BethGriggs
doc: assign missing deprecation code
343c6ac 
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@richardlau richardlau mentioned this pull request Jul 14, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardlau @addaleax @BethGriggs @targos @nodejs-github-bot