Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: convert BE-utf16-string to LE before search #3295

Closed
wants to merge 1 commit into from
Closed

src: convert BE-utf16-string to LE before search #3295

wants to merge 1 commit into from

Conversation

skomski
Copy link
Contributor

@skomski skomski commented Oct 9, 2015

On Big Endian platforms v8 strings are need to converted
to Little Endian before searching in utf16le buffer

Fixes #3283

@skomski
src: convert BE-utf16-string to LE before search
4c3655e 
On Big Endian platforms v8 strings are need to converted
to Little Endian before searching in utf16le buffer
@skomski skomski force-pushed the fix-big-endian-string-search branch from 34cf018 to 4c3655e Compare October 9, 2015 16:26
@silverwind silverwind added the buffer Issues and PRs related to the buffer subsystem. label Oct 9, 2015
@skomski skomski mentioned this pull request Oct 9, 2015
Closed
@trevnorris
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/464/

@mhdawson
Copy link
Member

mhdawson commented Oct 9, 2015

CI run to validate for plinux platforms https://ci.nodejs.org/job/node-test-commit-plinux/4/

Results show test passed on pLinux BE with this change

@trevnorris
Copy link
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Oct 10, 2015
@skomski @jasnell
src: convert BE-utf16-string to LE before search
9148114 
On Big Endian platforms v8 strings are need to converted
to Little Endian before searching in utf16le buffer

Fixes: #3283
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
PR-URL: #3295
@jasnell
Copy link
Member

jasnell commented Oct 10, 2015

Landed in master in 9148114.

jasnell pushed a commit that referenced this pull request Oct 10, 2015
@skomski @jasnell
src: convert BE-utf16-string to LE before search
589287b 
On Big Endian platforms v8 strings are need to converted
to Little Endian before searching in utf16le buffer

Fixes: #3283
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
PR-URL: #3295
@jasnell
Copy link
Member

jasnell commented Oct 10, 2015

Landed in v4.x in 589287b

@jasnell jasnell closed this Oct 10, 2015
@jasnell jasnell mentioned this pull request Oct 10, 2015
Closed
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 12, 2015
@skomski @Trott
src: convert BE-utf16-string to LE before search
dfe6788 
On Big Endian platforms v8 strings are need to converted
to Little Endian before searching in utf16le buffer

Fixes: nodejs#3283
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
PR-URL: nodejs#3295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skomski @trevnorris @mhdawson @jasnell @silverwind @MylesBorins