Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: removes unused params #32694

Closed
wants to merge 1 commit into from
Closed

lib: removes unused params #32694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/fs/dir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class Dir {
);
}

readSync(options) {
readSync() {
if (this[kDirClosed] === true) {
throw new ERR_DIR_CLOSED();
}
Expand Down
6 changes: 3 additions & 3 deletions lib/internal/fs/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ function validateFileHandle(handle) {
throw new ERR_INVALID_ARG_TYPE('filehandle', 'FileHandle', handle);
}

async function writeFileHandle(filehandle, data, options) {
async function writeFileHandle(filehandle, data) {
let remaining = data.length;
if (remaining === 0) return;
do {
Expand Down Expand Up @@ -514,10 +514,10 @@ async function writeFile(path, data, options) {
}

if (path instanceof FileHandle)
return writeFileHandle(path, data, options);
return writeFileHandle(path, data);

const fd = await open(path, flag, options.mode);
return writeFileHandle(fd, data, options).finally(fd.close);
return writeFileHandle(fd, data).finally(fd.close);
}

async function appendFile(path, data, options) {
Expand Down