Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature of _write() in a comment #3248

Closed

Conversation

fabiosantoscode
Copy link
Contributor

I was reading up on the stream source code and tripped on this thing, decided to fix it.

<3

@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Oct 8, 2015
@brendanashworth
Copy link
Contributor

LGTM, do you mind changing the commit message to be prefixed with stream: ? (example: 50daee7)

This comment was a bit misleading, since it was missing the `encoding`
argument.
@fabiosantoscode
Copy link
Contributor Author

There it is @brendanashworth, force pushed.

brendanashworth pushed a commit that referenced this pull request Oct 14, 2015
This comment was a bit misleading, since it was missing the `encoding`
argument.

PR-URL: #3248
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
@brendanashworth
Copy link
Contributor

Thanks @fabiosantoscode, landed in 85b74de.

@MylesBorins
Copy link
Contributor

This should likely be in LTS /cc @jasnell

jasnell pushed a commit to jasnell/node that referenced this pull request Oct 26, 2015
This comment was a bit misleading, since it was missing the `encoding`
argument.

PR-URL: nodejs#3248
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

Landed in v4.x-staging in 7e043b8

jasnell pushed a commit that referenced this pull request Oct 26, 2015
This comment was a bit misleading, since it was missing the `encoding`
argument.

PR-URL: #3248
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
jasnell pushed a commit that referenced this pull request Oct 29, 2015
This comment was a bit misleading, since it was missing the `encoding`
argument.

PR-URL: #3248
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants