build: disable -Wattributes warnings on aix #32419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the following compiler warning:
warning: visibility attribute not supported in this
configuration; ignored [-Wattributes]
This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.
bnoordhuis
added
build
cjihrig
approved these changes
Mar 22, 2020
richardlau
approved these changes
Mar 22, 2020
jasnell
approved these changes
Mar 22, 2020
addaleax
added
the
author ready
addaleax
approved these changes
Mar 29, 2020
addaleax
pushed a commit
that referenced
this pull request
Mar 29, 2020
Disable the following compiler warning:
warning: visibility attribute not supported in this
configuration; ignored [-Wattributes]
This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.
PR-URL: #32419
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 037f844 |
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
Disable the following compiler warning:
warning: visibility attribute not supported in this
configuration; ignored [-Wattributes]
This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.
PR-URL: #32419
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Disable the following compiler warning:
warning: visibility attribute not supported in this
configuration; ignored [-Wattributes]
This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.
PR-URL: #32419
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the following compiler warning:
This is gcc complaining about
__attribute((visibility("default"))in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.