Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove *.pyc files from deps/npm #32387

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Conversation

bnoordhuis
Copy link
Member

These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

Refs: #32368
Refs: npm/cli#1037

I'm proposing fast-tracking this because it's annoying.

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Mar 20, 2020
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

+1 to fast-track

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 20, 2020
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: nodejs#32387
Refs: nodejs#32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@bnoordhuis bnoordhuis merged commit fbecc07 into nodejs:master Mar 20, 2020
@bnoordhuis bnoordhuis deleted the rm-npm-pyc branch March 20, 2020 14:12
@bnoordhuis
Copy link
Member Author

Landed in fbecc07.

BethGriggs pushed a commit that referenced this pull request Mar 23, 2020
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 1, 2020
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: nodejs#32387
Refs: nodejs#32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Apr 1, 2020
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

Backport-PR-URL: #32527
PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Apr 3, 2020
@BethGriggs BethGriggs mentioned this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants